Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bugfixes #307

Merged
merged 5 commits into from
Jun 29, 2024
Merged

Fix/bugfixes #307

merged 5 commits into from
Jun 29, 2024

Conversation

belerico
Copy link
Member

Summary

This PR solves multiple bugs, in particular:

  • It fixes the numpy version to be <2.0
  • the unwrap_fabric method extracts first the .module from the _FabricModule returning the original module, also unwrapped from the Strategy: this prevents errors with the deepcopy
  • Fixes various tests

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Screenshots or Visuals (Optional)

If applicable, please provide screenshots, diagrams, graphs, or videos of the changes, features or the error.

Additional Information (Optional)

Please provide any additional information that may be useful for the reviewer, such as:

  • Any potential risks or challenges associated with the changes.
  • Any instructions for testing or running the code.
  • Any other relevant information.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico merged commit c8e6522 into main Jun 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants