Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ms-python.pylint #659

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Add ms-python.pylint #659

merged 1 commit into from
Feb 27, 2023

Conversation

curbengh
Copy link
Contributor

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR adds the missing "ms-python.pylint" extension for python linting, the default linter used by the "ms-python.python" extension. This extension has the same author as "ms-python.python". Installed the build on VSCodium 1.74.3 and it functions just fine.

@filiptronicek
Copy link
Member

Hey there @curbengh 👋, thanks a lot for raising the PR.

The changes look good, thanks for testing them on VSCodium as well!

I'm just unsure about the fact that the package Microsoft provides is about 7 times larger than ours 🤔, I wonder why.

image

@filiptronicek filiptronicek added the extension Regarding an extension label Feb 27, 2023
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it looks like the size difference was because of me not using Python 3.7 for validation. Thanks again!

@filiptronicek filiptronicek merged commit 2ca20e2 into EclipseFdn:master Feb 27, 2023
@cavcrosby cavcrosby mentioned this pull request Sep 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Regarding an extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants