Add a pypi badge #54
Merged
Add a pypi badge #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ authors: | |||
| orcid: "https://orcid.org/0000-0000-0000-0000" | |||
There was a problem hiding this comment.
Please add Yang's and your information to this file, too.
CITATION.cff
Outdated
| @@ -9,7 +9,7 @@ authors: | |||
| orcid: "https://orcid.org/0000-0000-0000-0000" | |||
| date-released: 20??-MM-DD | |||
There was a problem hiding this comment.
Let's add the date in this PR too, e.g. 2022-11-24 or 25
| @@ -60,7 +61,7 @@ conda environment before submitting the the bash script. See | |||
| ### On CRIB | |||
|
|
|||
| [CRIB](https://crib.utwente.nl/) is the ITC Geospatial Computing Platform. You | |||
| can run the model using `Matlab` or `Octave`. Currently, running the | |||
| can run the model using `Matlab` or `Octave`. Currently, running the | |||
| exceutable file on CRIB is not supported because MATLAB Runtime can not be | |||
| installed there. See [Install PyStemmusScope](#install-pystemmusscope). | |||
There was a problem hiding this comment.
There are two commands below that uses pip install from main branch. when pystemmusscope is published on pypi, we can install it by pip install pystemmusscope. Shall we fix the commands in this PR?
SarahAlidoost
requested changes
Nov 24, 2022
There was a problem hiding this comment.
@BSchilperoort thanks for the changes and fixing the linter 👍 please see my comments.
|
Kudos, SonarCloud Quality Gate passed! |
SarahAlidoost
approved these changes
Nov 24, 2022
|
Thanks a lot, Sarah, Bart, Yang, this is cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the pypi version badge to the README.md.
The version has been bumped to 0.1.1, this will allow us to properly test the Action that pushes the new releases to pypi.
pyroma(setup.cfg missing "python_requires" in[options]).Closes #52