Skip to content

Commit

Permalink
docs: add todos
Browse files Browse the repository at this point in the history
  • Loading branch information
danielgordon-switch-ev committed Aug 4, 2022
1 parent 85cae96 commit 003a108
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions iso15118/secc/states/iso15118_2_states.py
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,10 @@ async def process_message(
# TODO Either an MO Root certificate or a V2G Root certificate
# could be used to verify, need to be flexible with regards
# to the PKI that is used.
# TODO GitHub#94: If root_cert is not present, we should
# fall back to sending the leaf and sub-CA certificates,
# allowing the CSMS to attempt to retrieve the root certificate
# and construct the OCSP data itself.
root_cert_path = self._mobility_operator_root_cert_path()
root_cert = load_cert(root_cert_path)
verify_certs(leaf_cert, sub_ca_certs, root_cert)
Expand Down
2 changes: 1 addition & 1 deletion iso15118/shared/messages/enums.py
Original file line number Diff line number Diff line change
Expand Up @@ -423,5 +423,5 @@ class Contactor(IntEnum):

class AuthorizationTokenType(str, Enum):
EMAID = "eMAID"
# TODO: Do we need to define this in a more complete way?
# TODO GitHub#95: Do we need to define this in a more complete way?
EXTERNAL = "external"
2 changes: 1 addition & 1 deletion iso15118/shared/security.py
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,7 @@ def derive_certificate_hash_data(
try:
responder_url = get_ocsp_url_for_certificate(certificate)
except (ExtensionNotFound, OCSPServerNotFoundError):
# TODO: This may just result in failure down the road.
# TODO GitHub#96: This may just result in failure down the road.
# Should we let this fail on these exceptions, or is there
# another way to try to get a responder_url?
responder_url = "https://www.example.com/"
Expand Down

0 comments on commit 003a108

Please sign in to comment.