Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve logging/ab#2898 #139

Merged
merged 11 commits into from
Sep 30, 2022
Merged

Conversation

santiagosalamandri
Copy link
Contributor

This PR modifies Log levels:

  • INFO level for TCP/TLS messages
  • DEGUG level for 'waiting for up to ... sec' message
  • INFO level for "chosen protocol" message
  • INFO level for details on Request/Response messages

It also adds logs for project settings (env. variables) at start-up. It includes shared and EVCC/SECC-specific settings.

@santiagosalamandri santiagosalamandri force-pushed the feat/improve_logging/AB#2898 branch from 924cdee to f581a47 Compare September 30, 2022 10:23
@@ -23,4 +23,6 @@
)

ENABLE_TLS_1_3 = env.bool("ENABLE_TLS_1_3", default=False)

shared_settings = env.dump()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion - would be good to call env.dump() after env.seal()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right. Done.

@santiagosalamandri santiagosalamandri merged commit 17252a1 into master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants