Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run code qual and tests in gha #147

Merged
merged 4 commits into from
Oct 17, 2022
Merged

feat: run code qual and tests in gha #147

merged 4 commits into from
Oct 17, 2022

Conversation

mdwcrft
Copy link
Contributor

@mdwcrft mdwcrft commented Oct 17, 2022

  • Add mypy as a dev dependency
  • Update makefile to run code qual via poetry
  • Run code qual and tests as part of GHA
  • MyPy isn't run yet as it will fail, this should be addressed as part of the issue Use mypy #93

@mdwcrft mdwcrft mentioned this pull request Oct 17, 2022
Merged
tropxy
tropxy approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@tropxy tropxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just needs a rebase

@mdwcrft mdwcrft merged commit 72e8cc9 into master Oct 17, 2022
shalinnijel2 added a commit that referenced this pull request Nov 2, 2022
@shalinnijel2
Squashed commit of the following:
0ca196f 
commit 2c30797
Author: Ibrahim KARATAS <89934937+ikaratass@users.noreply.github.com>
Date:   Mon Oct 31 17:19:10 2022 +0000

    Fix/genchallange invalid (#154)

    * genchallance will only sent on first AuthorizationReq message

    * test_authorization_req_gen_challenge_invalid unit test modified

commit 0d34ee5
Author: Ibrahim KARATAS <89934937+ikaratass@users.noreply.github.com>
Date:   Mon Oct 31 16:36:56 2022 +0000

    genchallange check has been added for Authorization (#135)

    * The genchallange check has been added for Authorization

commit 6192609
Author: Chad <34003459+mdwcrft@users.noreply.github.com>
Date:   Mon Oct 31 14:43:25 2022 +0000

    fix: cleanup template dockerfile (#109)

commit 5185483
Author: Roman Stanchak <rstanchak@gmail.com>
Date:   Mon Oct 24 05:35:44 2022 -0400

    fix: use utcnow() to check certificate validity (#151)

commit 72e8cc9
Author: Chad <34003459+mdwcrft@users.noreply.github.com>
Date:   Mon Oct 17 17:29:49 2022 +0100

    feat: run code qual and tests in gha (#147)

    * feat: run code qual and tests in gha

    * fix: install deps in gha

    * fix: add isort make command

commit 8718dd5
Author: santiagosalamandri <santiago@switch-ev.com>
Date:   Mon Oct 17 15:02:36 2022 +0100

    Bump 0.13.0 (#149)

    * feat: Bump to 0.13.0

commit d596370
Author: Santiago Salamandri <santiago@switch-ev.com>
Date:   Mon Oct 17 13:59:40 2022 +0100

    feat: Pass status event as a parameter to start servers. Reduce check status delay to 10 mS

commit 8d260e2
Author: Santiago Salamandri <santiago@switch-ev.com>
Date:   Mon Oct 17 13:56:38 2022 +0100

    feat: Remove event atribute and pass it as a parameter

commit da2ee49
Author: Santiago Salamandri <santiago@switch-ev.com>
Date:   Mon Oct 17 13:55:04 2022 +0100

    chore: rename EVSEServiceStatus to ServiceStatus

commit 3898096
Author: Santiago Salamandri <santiago@switch-ev.com>
Date:   Mon Oct 17 12:11:47 2022 +0100

    feat: Add starting status

commit 657d451
Author: Santiago Salamandri <santiago@switch-ev.com>
Date:   Mon Oct 17 12:11:11 2022 +0100

    feat: Add a task to check the servers status

commit 222b741
Author: Santiago Salamandri <santiago@switch-ev.com>
Date:   Mon Oct 17 12:09:30 2022 +0100

    feat: Add ready status events to servers

commit f196eb6
Author: Santiago Salamandri <santiago@switch-ev.com>
Date:   Mon Oct 17 12:08:21 2022 +0100

    feat: Implemented set_status method

commit c076bb2
Author: Santiago Salamandri <santiago@switch-ev.com>
Date:   Mon Oct 17 12:07:38 2022 +0100

    feat: add evse status enum and set_status abstract method

commit b0e4f25
Author: Chad <34003459+mdwcrft@users.noreply.github.com>
Date:   Wed Oct 12 13:54:56 2022 +0100

    fix: remove sphinx dependency (#141)

commit 15c3a5a
Author: André <andre14x@gmail.com>
Date:   Wed Oct 12 11:39:27 2022 +0100

    get from the evse controller the ac evse status (#146)

    * get from the evse controller the ac evse status

    * removed unused iimport

    * added test for charging status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tropxy tropxy tropxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdwcrft @tropxy