Feat/external auth #163
Merged
Feat/external auth #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalinnijel2
suggested changes
Nov 18, 2022
|
Apart from the change in the simulator, the rest lgtm. |
ikaratass
force-pushed
the
feat/external_auth
branch
from
558aad6 to
030ca79
Compare
tropxy
requested changes
Nov 22, 2022
Comment on lines
203
to
206
| it returns true when an RFID card tapped before plugging in | ||
| and authorization is successful afterwards. | ||
| Relevant for: | ||
| - DIN SPEC 70121 | ||
| - ISO 15118-2 | ||
| - ISO 15118-20 |
There was a problem hiding this comment.
not only RFID as it can be a pin code authentication. Is better that we say " it returns true when an external authentication attempt is successful (eg RFID, pin code, ...) and false otherwise
ikaratass
force-pushed
the
feat/external_auth
branch
from
fd63fe0 to
70ea999
Compare
shalinnijel2
approved these changes
Nov 22, 2022
tropxy
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is removed Contract from the PaymentOptionsList when external authorization is done.