Support 15118-20 DC BPT #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalinnijel2
force-pushed
the
dc_dc_bpt
branch
2 times, most recently
from
cc206ad to
2884f38
Compare
tropxy
requested changes
Dec 9, 2022
Modified existing method to specify protocol. Protocol is passed in to help determine the expected return type.
…h for ac/dc/ac_bpt/dc_bpt cl param requests.
shalinnijel2
force-pushed
the
dc_dc_bpt
branch
from
96ec3ad to
18f4a42
Compare
tropxy
reviewed
Dec 20, 2022
Comment on lines
+1493
to
+1500
| if not await self.comm_session.evse_controller.is_contactor_closed(): | ||
| self.stop_state_machine( | ||
| "Contactor didnt close for Cable Check", | ||
| message, | ||
| ResponseCode.FAILED, | ||
| ) | ||
| return | ||
| await self.comm_session.evse_controller.start_cable_check() |
There was a problem hiding this comment.
as I mentioned to you before, we need to invert this. First we start cable check, then we check if the contactors are closed
There was a problem hiding this comment.
I will approve the PR, so I dont block your work, but change that if you can ;)
There was a problem hiding this comment.
Yes have created a ticket here.
tropxy
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes: