Fix: SessionSetupReq in -20 had the wrong V2GTP type #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropxy
approved these changes
Jan 26, 2023
shalinnijel2
force-pushed
the
incorrect_v2gtp_type
branch
from
3786d92 to
36191ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessionSetupReq was being sent from EVCC with the wrong V2GTP type 0x8001 (ISOV20PayloadTypes.SAP). Updated evcc/../sap_states.py to set
next_payload_typeto be ISOV20PayloadTypes.MAINSTREAMThis went unnoticed till now because the schema to be used for decoding the exi was first decided based on the protocol set in comm_session. Plus the fallback for unmatched v2gtp type was ISOV20PayloadTypes.MAINSTREAM and this unintentionally patched the issue at the secc end.
https://github.com/SwitchEV/iso15118/blob/2b146b483996863e82fca111db33dabf39f293fc/iso15118/shared/comm_session.py#L141
https://github.com/SwitchEV/iso15118/blob/2b146b483996863e82fca111db33dabf39f293fc/iso15118/shared/comm_session.py#L142