Feat/update docker config #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagosalamandri
force-pushed
the
feat/update_docker_config
branch
from
6cb7a5e to
967157c
Compare
santiagosalamandri
force-pushed
the
feat/update_docker_config
branch
from
21bb719 to
f3de262
Compare
tropxy
requested changes
Jan 26, 2023
Makefile
Outdated
| @@ -56,6 +56,8 @@ build: .generate_v2_certs | |||
| @# This conversion is required, otherwise we wouldn't be able to spawn the evcc start script. | |||
| @# @ is used as a separator and allows us to escape '/', so we can substitute the '/' itself | |||
| @sed -i.bkp 's@/secc/g@/evcc/g@g' iso15118/evcc/Dockerfile | |||
| @# Add a delay on EVCC to give SECC time to start up | |||
| @sed -i 's/CMD\ \/venv\/bin\/iso15118/CMD\ echo\ "Waiting for 5 seconds to start EVCC"\ \&\&\ sleep\ 5\ \&\&\ \/venv\/bin\/iso15118/g' iso15118/evcc/Dockerfile | |||
There was a problem hiding this comment.
dont you prefer to use the nomenclature above with the "@" I think it is cleaner to the human eye
santiagosalamandri
force-pushed
the
feat/update_docker_config
branch
from
48fe701 to
e728969
Compare
shalinnijel2
approved these changes
Jan 27, 2023
cool ;) just updated your description to link the PR with those opened issues, so they are closed automatically |
tropxy
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
fixes #192, fixes #194