Start TCP server after an SDP request is received. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropxy
requested changes
Feb 17, 2023
| self.tcp_server_handler = None | ||
| self.udp_server.resume_udp_server() | ||
|
|
||
| async def start_tcp_server(self, tls_enabled: bool): |
There was a problem hiding this comment.
can you change the flag name tls_enabled to with_tls ? makes more sense I think
tropxy
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
One minor change V2GCommunicationSession - we were relying on
self.writer.get_extra_info('peername')to get the ip address of the remote connection - this is used as a key inself.comm_sessionsdictionary. However, when the connection is reset,self.writer.get_extra_info('peername')would return None and any look up in the dictionary would fail. The call has been replaced with a member variable that holds the value (populated when the peer connection is available).