terminate java gateway on exit #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalinnijel2
force-pushed
the
hotfix/terminate-java-gateway
branch
from
a30c534 to
151316c
Compare
shalinnijel2
approved these changes
May 22, 2023
|
I gave it a quick check and my end and saw it working. Thank you for your contribution @rstanchak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a situation running the iso15118 stack where the java background process spawned by JavaGateway was not getting terminated under certain conditions.
The issue can be replicated as follows:
=> the java process remains
I ran into this issue while using a unit test framework and ended up with 100s of java processes running in the background which eventually used up all my RAM.
This patch fixes the issue for me both in the unit test framework and when force-killing the parent process. The die_on_exit argument causes the die-on-broken-pipe flag to be passed to the java gateway, which terminates the gateway if the stdin pipe is broken.