Add missing optional fileds in CurrentDemandRes DIN70121 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sdrabb
commented
Jun 20, 2023
•
sdrabb
commented
- Add missing optional fields evse_max_current_limit, evse_max_voltage_limit, evse_max_power_limit inside CurrentDemandRes DIN70121
sdrabb
changed the title
shalinnijel2
previously approved these changes
Jun 21, 2023
|
Hi @sdrabb, thank you for the changes. I see a separate branch was not created while creating this PR, perhaps why I couldn't rebase. Could you create the same PR on a separate branch, please? |
- Add missing optional fields evse_max_current_limit, evse_max_voltage_limit, evse_max_power_limit inside CurrentDemandRes
|
@shalinnijel2 I fork your project, I'm using the forked repo https://github.com/SwitchEV/iso15118-am/tree/master Anyway I rebase the master, can you try it now? |
shalinnijel2
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.