Simplify instructions to run locally #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting the python scripts using `poetry run python <script>` instead of `python <script>`. The call to `poetry run` already activates the virtual environment, making an explicit call to `poetry shell` obsolete.
tropxy
reviewed
Sep 20, 2023
| @@ -83,11 +83,11 @@ poetry-shell: | |||
|
|
|||
| # Run evcc with python | |||
| run-evcc: | |||
| $(shell which python) iso15118/evcc/main.py $(config) | |||
| poetry run python iso15118/evcc/main.py $(config) | |||
There was a problem hiding this comment.
I had some issues in the past running it like that in a Mac.
Can someone confirm this? @mdwcrft @snorkman88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the python scripts using
poetry run python <script>instead ofpython <script>. The call topoetry runalready activates the virtual environment, making an explicit call topoetry shellobsolete.