feat: Support for 15118-20 #33
Conversation
Condition that returned None for ScheduledExchangeRes Dynamic_SEResControlMode/Scheduled_SEResControlMode has been removed.
| logger.warning( | ||
| "PrivateKeyReadError occurred while trying to create " | ||
| "signature for CertificateInstallationReq. Falling back to sending " | ||
| f"AuthorizationReq instead.\n{exc}" |
There was a problem hiding this comment.
is this defined in the standard?
There was a problem hiding this comment.
In the current implementation - AuthorisationReq is sent after AuthorisationSetupRes is received if any of the following conditions matches:
- AuthorisationSetupRes has CertificateInstallationService set to False or EVCC decides it doesn't want certificates installed ( self.comm_session.ev_controller.is_cert_install_needed())
- CertificateInstallationService in AuthorisationSetupRes is True and self.comm_session.ev_controller.is_cert_install_needed() is True.
self.comm_session.ev_controller.is_cert_install_needed() suggests EVCC has a say in the matter (as in could it continue sending AuthorisationSetupReq even though CertificationInstallationService was set to true by SECC) and can decide against having certificates installed. This possibility is used by EVCC in the current implementation as a fallback to send AuthorizationReq in case it fails to generate the signature used to build CertificateInstallationReq. My understanding is this what is happening above. Is that correct , @MarcMueltin ?
In the spec the reason EVCC could say no certificate installation is required is if it already has the required contract certificates. Otherwise, it is expected to go through CertificateIntstallation-AuthorizationSetupReq loop until RemainingContractCertificateChains is 0.
Addressed comments on EVCC side for -20 implementation.