Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional is_precharge flag to send_charging_command #364

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

shalinnijel2
Copy link
Contributor

@shalinnijel2 shalinnijel2 commented Jan 12, 2024

Added is_precharge flag to send_charging_command. Required as we use the same method during charging loop and precharge.

@shalinnijel2 shalinnijel2 marked this pull request as ready for review January 12, 2024 07:58
@shalinnijel2 shalinnijel2 changed the title Add is_precharge flag to send_charging_command Added optional is_precharge flag to send_charging_command Jan 12, 2024
Copy link
Collaborator

@ikaratass ikaratass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shalinnijel2 shalinnijel2 force-pushed the update_send_charging_command_method branch from fb60046 to 6033693 Compare January 22, 2024 09:28
@shalinnijel2 shalinnijel2 merged commit aeb48d8 into master Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants