Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share display params with CS. #401

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

shalinnijel2
Copy link
Contributor

Share display params coming from EV with the CS. This doesn't apply to -2 AC though - as the request is empty.

@shalinnijel2 shalinnijel2 requested a review from ikaratass April 29, 2024 14:31
"""
Share display params with CS.
"""
pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good if we can add an info message

ikaratass
ikaratass previously approved these changes Apr 30, 2024
Copy link
Collaborator

@ikaratass ikaratass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Collaborator

@ikaratass ikaratass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@shalinnijel2 shalinnijel2 merged commit 54a4e2e into master Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants