Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add details discovered in running locally #43

Merged
merged 2 commits into from
May 20, 2022

Conversation

danielgordon-switch-ev
Copy link
Contributor

This PR adds some details I learned in trying to get make run-secc to succeed in a local installation.

This is meant to be a quick PR with more to follow -- I think this could be restructured some more to make the setup process easier to follow, but will do that in a separate PR.

Another question: does this actually only run on Linux? If so, do we know why it doesn't run on MacOS? The final section, "Integration Test with an EV Simulator", indicates that it has been run successfully under Ubuntu, Debian, and MacOS (which versions?)

Comment on lines +72 to +73
Then follow the instructions to configure your desired version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these detailed instructions, Daniel. Also, as users are likely to try and start execute the code before reading through the entire document, do you think it would help to point out the .env settings here, right after the java update instructions? A comment suggesting - "Configure .env file as suggested here (https://github.com/SwitchEV/iso15118#environment-settings)" would suffice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's definitely something I have in mind for my next PR -- to rearrange the existing information so that people are presented with what they need to get up and running right away. I thought it might be simpler to add the additional instructions first, then restructure the document in a second PR, since both together could be hard to follow.

README.md Outdated
@@ -130,6 +150,10 @@ it is required to create a `.env` file, containing the required settings.
This means, if development settings are desired, one can simply copy the contents
of `.env.dev.local` to `.env`.

By default, `.env.dev.local` assumes the presence of an `eth0` network interface.
If you are not using ethernet, replace the `NETWORK_INTERFACE` value in your local `.env`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you meant "if you are not using eth0 as your network interface, replace the ....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will clarify.

@danielgordon-switch-ev danielgordon-switch-ev merged commit f27e7af into master May 20, 2022
@danielgordon-switch-ev danielgordon-switch-ev deleted the docs/improve-readme branch May 20, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants