chore: use lockfile instead of poetry update #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgordon-switch-ev
requested review from
tropxy,
snorkman88,
mdwcrft and
shalinnijel2
HugoJP1
approved these changes
May 23, 2022
Added a ticket: https://dev.azure.com/switch-ev/Josev/_workitems/edit/1970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick PR to avoid using
poetry updateon every Docker build. This is so that dependencies will not change on different Docker builds, unless we have changed the lockfile withpoetry lock. This will help make builds more reproducible.I will include changes to the README to remove references to
poetry updatein my upcoming PR related to the README.