fixed order of closing contactor and reformated the code #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalinnijel2
suggested changes
Jun 20, 2022
There was a problem hiding this comment.
Just that close_contactor is missing in din_spec. Else lgtm.
Also set_hlc_charging(True/False) is missing in -20.
So, to summarise, the order of events for all protocols would be:
- Start/Stop HLC
- Stop charger (only if ChargeProgress equals stop charging)
- Open/Close contactor
…it to -20 and DIN spec; added tests and refactored them as well
shalinnijel2
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.