Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1090 physical types validation error #7

Merged
merged 7 commits into from
Dec 28, 2021
Merged

Fix 1090 physical types validation error #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0af834c
Fixed max value validation for the PhysicalValue types
tropxy Dec 23, 2021
35f6fec
Changed multiplier to test the changes
tropxy Dec 23, 2021
a37fd3b
On favour of DRY, I moved the root_validator of the PhysicalTypes to …
tropxy Dec 24, 2021
b84bd91
added extra comment related to the private method validation with pyd…
tropxy Dec 24, 2021
cf88330
changed physical value restrictions after comments by Marc
tropxy Dec 28, 2021
45ade3c
Revert "changed physical value restrictions after comments by Marc"
tropxy Dec 28, 2021
977e050
used the enums for a few fields
tropxy Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iso15118/evcc/controller/simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def get_charge_params_v2(self) -> ChargeParamsV2:
ev_max_voltage = PVEVMaxVoltage(
multiplier=0, value=400, unit=UnitSymbol.VOLTAGE
)
ev_max_current = PVEVMaxCurrent(multiplier=0, value=16, unit=UnitSymbol.AMPERE)
ev_max_current = PVEVMaxCurrent(multiplier=-3, value=32000, unit=UnitSymbol.AMPERE)
ev_min_current = PVEVMinCurrent(multiplier=0, value=10, unit=UnitSymbol.AMPERE)
ac_charge_params = ACEVChargeParameter(
departure_time=0,
Expand Down
6 changes: 5 additions & 1 deletion iso15118/shared/messages/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@

logger = logging.getLogger(__name__)

INT_32_MAX = 4294967295
UINT_32_MAX = 2**32 - 1
INT_16_MAX = 2**15 - 1
INT_16_MIN = -2**15
INT_8_MAX = 2**7 - 1
INT_8_MIN = -2**7


class AuthEnum(str, Enum):
Expand Down
Loading