Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/iso din bringup on comemso #86

Merged
merged 11 commits into from
Sep 15, 2022
Merged

Feature/iso din bringup on comemso #86

merged 11 commits into from
Sep 15, 2022

Conversation

martinbachmanndesignwerk
Copy link
Contributor

@martinbachmanndesignwerk martinbachmanndesignwerk commented Jul 29, 2022 •
edited by tropxy
Loading

We have successfully charged iso15118-2 and din on our comemso multimobile protocol tester. I've unittests with test json from the charging session to verify message creation works.

fix #70

@martinbachmanndesignwerk martinbachmanndesignwerk force-pushed the feature/iso_din_bringup_on_comemso branch 2 times, most recently from 6915510 to e18f953 Compare July 29, 2022 12:27
@tropxy
Copy link
Contributor

tropxy commented Aug 8, 2022

Hi @martinbachmanndesignwerk ! thanks for this contribution. I quickly went through it and looks good; I want to give it a deeper look, but before that could you rebase your branch against latest master and solve the conflicts?

thanks!

@martinbachmanndesignwerk martinbachmanndesignwerk force-pushed the feature/iso_din_bringup_on_comemso branch from 471521e to 4d76bbc Compare August 15, 2022 05:44
@martinbachmanndesignwerk
Copy link
Contributor Author

Hi @martinbachmanndesignwerk ! thanks for this contribution. I quickly went through it and looks good; I want to give it a deeper look, but before that could you rebase your branch against latest master and solve the conflicts?

thanks!

Done... Ready for review... :-)

@bachmmmar
Copy link

Hi @martinbachmanndesignwerk ! thanks for this contribution. I quickly went through it and looks good; I want to give it a deeper look, but before that could you rebase your branch against latest master and solve the conflicts?

thanks!

Hi @tropxy
When do you think will it be possible to look into that PR?
Regards,
Martin

@bachmmmar bachmmmar mentioned this pull request Aug 31, 2022
Closed
tropxy
tropxy requested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@tropxy tropxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi it looks good just needs rebasing again

@tropxy tropxy force-pushed the feature/iso_din_bringup_on_comemso branch from 4d76bbc to 1276c12 Compare September 15, 2022 13:43
@tropxy
Copy link
Contributor

tropxy commented Sep 15, 2022

I rebased and looks good, so I am merging it. Thanks @martinbachmanndesignwerk!!

@tropxy tropxy merged commit e8b5da0 into EcoG-io:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tropxy tropxy tropxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in PowerDeliveryReq when sending DCEVPowerDeliveryParameter
3 participants
@martinbachmanndesignwerk @tropxy @bachmmmar