Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong message parameters will return FAILED_WRONG_CHARGE_PARAMETER #87

Merged
merged 1 commit into from
Aug 26, 2022
Merged

fix: wrong message parameters will return FAILED_WRONG_CHARGE_PARAMETER #87

merged 1 commit into from
Aug 26, 2022

Conversation

ikaratass
Copy link
Collaborator

@ikaratass ikaratass commented Jul 29, 2022 •
edited
Loading

Fixed AB#2522

For the ChargeParameterDiscoveryReq, it is supposed to be return FAILED_WRONG_CHARGE_PARAMETER when a wrong parameter received.

@ikaratass ikaratass requested review from shalinnijel2 and tropxy July 29, 2022 16:31
@ikaratass
Copy link
Collaborator Author

https://github.com/SwitchEV/josev_pro/issues/90

@tropxy
Copy link
Contributor

tropxy commented Aug 1, 2022

there is no description in the PR of what it is supposed to fix or a reference to a sprint ticket.

"wrong message parameters will return FAILED_WRONG_CHARGE_PARAMETER" doesnt tell me what is the problem.
can you elaborate on that?

tropxy
tropxy requested changes Aug 1, 2022
View reviewed changes
iso15118/shared/exi_codec.py Outdated Show resolved Hide resolved
iso15118/shared/messages/din_spec/body.py Outdated Show resolved Hide resolved
iso15118/shared/messages/iso15118_2/body.py Outdated Show resolved Hide resolved
@ikaratass ikaratass changed the title wrong message parameters will return FAILED_WRONG_CHARGE_PARAMETER fix: wrong message parameters will return FAILED_WRONG_CHARGE_PARAMETER Aug 1, 2022
@ikaratass ikaratass requested a review from tropxy August 1, 2022 11:38
tropxy
tropxy requested changes Aug 8, 2022
View reviewed changes
iso15118/shared/messages/iso15118_2/body.py Outdated Show resolved Hide resolved
iso15118/shared/messages/iso15118_2/body.py Outdated Show resolved Hide resolved
iso15118/shared/exi_codec.py Outdated Show resolved Hide resolved
@ikaratass ikaratass requested a review from tropxy August 8, 2022 15:43
tropxy
tropxy previously approved these changes Aug 10, 2022
View reviewed changes
@ikaratass ikaratass force-pushed the fix/ChargeParameterDiscoveryReq branch from 15a92da to 35fdfcd Compare August 10, 2022 10:29
@ikaratass ikaratass requested a review from tropxy August 10, 2022 14:00
@ikaratass ikaratass requested a review from tropxy August 16, 2022 09:17
@tropxy
Copy link
Contributor

tropxy commented Aug 26, 2022

just rebase the branch and then I think is good to go

@ikaratass ikaratass force-pushed the fix/ChargeParameterDiscoveryReq branch from e810afb to 4f5df58 Compare August 26, 2022 16:25
@ikaratass ikaratass force-pushed the fix/ChargeParameterDiscoveryReq branch from 4f5df58 to 0c75211 Compare August 26, 2022 16:29
@tropxy tropxy merged commit 1d3f640 into master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tropxy tropxy tropxy approved these changes

@shalinnijel2 shalinnijel2 Awaiting requested review from shalinnijel2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikaratass @tropxy