Let users set their own energy costs. #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auce each resolver would need different properties to work with.
- Renamed the Calculator.php to RawCalculator.php, to keep the logic separated. - Added a CalculatorService.php to wrap the logic needed to call the RawCalculator.php.
…tep calculators, used the calculator service itself.
- added a new cast (non_rounding_float), which doesnt round..
- Macro to local scope.
- UpdateOrInsert and exists check, just to be sure.
# Conflicts: # app/Calculations/HeatPump.php # app/Console/Commands/RunDeploy.php # app/Services/Models/BuildingService.php # app/Services/UserService.php
Yinci
added
accepted
# Conflicts: # app/Calculations/Heater.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the users to set their own current energy costs for electricity and gas.