Skip to content

[DMS-867] Fix clients all sharing one socket pool#125

Merged
vimayya merged 1 commit intomainfrom
DMS-867
Nov 12, 2025
Merged

[DMS-867] Fix clients all sharing one socket pool#125
vimayya merged 1 commit intomainfrom
DMS-867

Conversation

@bradbanister
Copy link
Contributor

Prefer the current Locust user's HTTP client when constructing EdFiTaskSet instances and keep the shared class attribute only as a fallback. VolumeTestUser now rebinds EdFiAPIClient.client at the start of every user initialization so each simulated user maintains its own socket pool beyond 10 clients.

Prefer the current Locust user's HTTP client when constructing EdFiTaskSet instances and keep the shared class attribute only as a fallback. VolumeTestUser now rebinds EdFiAPIClient.client at the start of every user initialization so each simulated user maintains its own socket pool beyond 10 clients.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a socket pool sharing issue where all Locust clients were using a single shared connection pool. The fix ensures each simulated user maintains its own socket pool to properly simulate concurrent users in performance testing.

  • Moved client binding in VolumeTestUser to execute for every user instance instead of only during initialization
  • Added fallback logic in EdFiTaskSet to prefer per-user HTTP clients over shared class attributes
  • Enhanced backwards compatibility by maintaining the shared class attribute as a fallback

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
volume_tests.py Moved EdFiAPIClient.client assignment before the initialization check to ensure every user gets its own client binding
ed_fi_task_set.py Added logic to prefer the Locust user's HTTP client with fallback to shared class attribute for backwards compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vimayya vimayya merged commit 25573fb into main Nov 12, 2025
15 checks passed
@vimayya vimayya deleted the DMS-867 branch November 12, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants