Conversation
Prefer the current Locust user's HTTP client when constructing EdFiTaskSet instances and keep the shared class attribute only as a fallback. VolumeTestUser now rebinds EdFiAPIClient.client at the start of every user initialization so each simulated user maintains its own socket pool beyond 10 clients.
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a socket pool sharing issue where all Locust clients were using a single shared connection pool. The fix ensures each simulated user maintains its own socket pool to properly simulate concurrent users in performance testing.
- Moved client binding in VolumeTestUser to execute for every user instance instead of only during initialization
- Added fallback logic in EdFiTaskSet to prefer per-user HTTP clients over shared class attributes
- Enhanced backwards compatibility by maintaining the shared class attribute as a fallback
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| volume_tests.py | Moved EdFiAPIClient.client assignment before the initialization check to ensure every user gets its own client binding |
| ed_fi_task_set.py | Added logic to prefer the Locust user's HTTP client with fallback to shared class attribute for backwards compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vimayya
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer the current Locust user's HTTP client when constructing EdFiTaskSet instances and keep the shared class attribute only as a fallback. VolumeTestUser now rebinds EdFiAPIClient.client at the start of every user initialization so each simulated user maintains its own socket pool beyond 10 clients.