Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

docs: update CONTRIBUTING.md #1387

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

PritamSarbajna
Copy link
Member

@PritamSarbajna PritamSarbajna commented Jun 13, 2022

Fixes Issue

Closes #1386

Changes proposed

  • It is now more clear that why we use git add public as I have also mentioned that we can also use specific name of the folder we just changed
  • Added commit point separately
  • made Instead, stage your changes for each file/folder line as note and also added By using public path it means it will add all files and folders under that folder, it is better to be specific to it

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

It is looking like this after updating

Screenshot (115)

Note to reviewers

I am facing these problems so I thought it'll be helpful who are just starting out

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small changes, then this will be good to go.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@Panquesito7 Panquesito7 added the 📄 aspect: text undefined label Jun 16, 2022
@schmelto schmelto changed the title I have updated CONTRIBUTING.md docs: update CONTRIBUTING.md Jun 21, 2022
Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__
sema-logo  Summary: 👌 This code looks good

@EmmaDawsonDev EmmaDawsonDev merged commit 3bd757e into EddieHubCommunity:main Jul 12, 2022
@PritamSarbajna PritamSarbajna deleted the issue-1386 branch August 14, 2022 03:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] CONTRIBUTING.md needs improvement
3 participants