Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

chore: Added test cases skeleton for search #2082

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

Pradumnasaraf
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf commented Oct 31, 2022

Changes proposed

Added 3 test cases skeleton for search

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.

Screenshots

Screenshot 2022-10-31 at 6 29 18 PM

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added medium Pull request with changed lines between 10 and 30 v2 labels Oct 31, 2022
@Pradumnasaraf Pradumnasaraf changed the title chore: Added search test skeleton chore: Added Oct 31, 2022
@Pradumnasaraf Pradumnasaraf changed the title chore: Added chore: Added test cases skeleton for search Oct 31, 2022
@Pradumnasaraf
Copy link
Contributor Author

Ready for review, thank you :)

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@eddiejaoude eddiejaoude merged commit e8608b3 into EddieHubCommunity:nextjs Oct 31, 2022
@jaynarayan-vaishnav
Copy link
Contributor

hey @Pradumnasaraf just wanted to ask this how did you get that verified sign in front of your commits.
don't know if this is the right place to ask about this so sorry for the inconvinience i'll delete this comment if you say so.

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Oct 31, 2022

No worries, you can ask anywhere @jaynarayan-vaishnav. I have committed directly from the GitHub UI, so all of the commits done directly from it will be signed by default.

If you also want that your local git commits to getting signed, check out this official doc by GitHub..

If you still find difficulty, just search on Youtube "how to sign your git commit", you will find tons of videos.

@jaynarayan-vaishnav
Copy link
Contributor

Okay thanks for your help pradumna 😊

@Pradumnasaraf Pradumnasaraf deleted the nextjs branch February 23, 2023 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
medium Pull request with changed lines between 10 and 30
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants