Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Changed line 98. #2124

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Changed line 98. #2124

merged 1 commit into from
Nov 5, 2022

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Nov 5, 2022

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • [ X] My change requires changes to the documentation.
  • [X ] I have updated the documentation accordingly.
  • [ X] All new and existing tests passed.
  • [X ] This PR does not contain plagiarized content.
  • [ X] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I changed line 98. I also noticed that there's a line that says "public data file". Should that one be changed to?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added small Pull request with less than 10 changed lines v2 labels Nov 5, 2022
@CBID2
Copy link
Contributor Author

CBID2 commented Nov 5, 2022

Hi @eddiejaoude. This is the line that my question refers too:
"Create a file named using your GitHub username username.json in the directory public/data, this will ensure it is unique."
Should "public/data" be changed to "data"?

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eddiejaoude eddiejaoude merged commit f535099 into EddieHubCommunity:nextjs Nov 5, 2022
@CBID2 CBID2 deleted the patch-2 branch November 5, 2022 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request with less than 10 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants