Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Himanshu1221 patch 1 #3311

Merged
merged 14 commits into from
Jan 14, 2023
Merged

Himanshu1221 patch 1 #3311

merged 14 commits into from
Jan 14, 2023

Conversation

himanshu1221
Copy link
Contributor

@himanshu1221 himanshu1221 commented Jan 12, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Jan 12, 2023
@github-actions
Copy link
Contributor

Welcome @himanshu1221! Thank you so much for your first pull request!

@github-actions github-actions bot added the ✍ chore: profile This label will be added on PR with request of Data json addition label Jan 12, 2023
Copy link
Member

@Aadarsh805 Aadarsh805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the data/himanshu1221 without the .json one

@himanshu1221
Copy link
Contributor Author

delete the data/himanshu1221 without the .json one

done !

@senali-d
Copy link
Contributor

delete the data/himanshu1221 without the .json one

done !

@himanshu1221 Still the data/himanshu1221 without the .json file is there. Please remove it.

@github-actions github-actions bot added the LGTM label Jan 14, 2023
@himanshu1221
Copy link
Contributor Author

delete the data/himanshu1221 without the .json one

done !

@himanshu1221 Still the data/himanshu1221 without the .json file is there. Please remove it.

removed it maam yo can check it

Copy link
Contributor

@senali-d senali-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Good. Thank you for the contribution 🎉

Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. Thank you for your contribution! 🎉

@Pradumnasaraf Pradumnasaraf merged commit 0605423 into EddieHubCommunity:main Jan 14, 2023
@Aadarsh805 Aadarsh805 mentioned this pull request Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition large Pull request with more than 30 changed lines LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants