Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Create anubhav201241.json #452

Merged
merged 6 commits into from
Oct 7, 2021
Merged

Conversation

Anubhavdevv
Copy link
Member

@Anubhavdevv Anubhavdevv commented Oct 4, 2021

Added anubhav201241.json 🚀

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

package.json Show resolved Hide resolved
public/data/anubhav201241.json Outdated Show resolved Hide resolved
@Anubhavdevv Anubhavdevv requested a review from gptkrsh October 4, 2021 19:08
@eddiejaoude
Copy link
Member

Please remove the package-lock changes

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review package lock changes

@eddiejaoude eddiejaoude added the ✍ chore: profile This label will be added on PR with request of Data json addition label Oct 4, 2021
@Anubhavdevv
Copy link
Member Author

Sure @eddiejaoude Thanks for the review!

@Anubhavdevv
Copy link
Member Author

@eddiejaoude Can you please more specific what changes I need to made in package-lock file

@gptkrsh
Copy link
Contributor

gptkrsh commented Oct 5, 2021

Copy-paste the original file from this repo...

@Anubhavdevv
Copy link
Member Author

Copy-paste the original file from this repo...

Now is it good?

Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure doesn't seem done, try again

@Anubhavdevv
Copy link
Member Author

Anubhavdevv commented Oct 5, 2021

Not sure doesn't seem done, try again

I have copied the package.lock JSON file and paste it in the repo as well as make the necessary changes. Could you please specify which changes I should make?
image

@gptkrsh
Copy link
Contributor

gptkrsh commented Oct 5, 2021

Not sure doesn't seem done, try again

I have copied the package.lock JSON file and paste it in the repo as well as make the necessary changes. Could you please specify which changes I should make? image

Simply this json i think: https://raw.githubusercontent.com/anubhav201241/LinkFree/21a5012de9ea8b1eebb07dc978232f0cbf665140/package-lock.json

@Anubhavdevv
Copy link
Member Author

Not sure doesn't seem done, try again

I have copied the package.lock JSON file and paste it in the repo as well as make the necessary changes. Could you please specify which changes I should make? image

Simply this json i think: https://raw.githubusercontent.com/anubhav201241/LinkFree/21a5012de9ea8b1eebb07dc978232f0cbf665140/package-lock.json

Yup I have added this too please review it again

@Anubhavdevv Anubhavdevv requested a review from gptkrsh October 5, 2021 07:17
Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anubhavdevv
Copy link
Member Author

Not sure why this appears: https://github.com/EddieHubCommunity/LinkFree/pull/452/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519 if you have fixed the package-lock issue

Do you mean I have to change this I have to format it properly and add a new line in it?
image

@gptkrsh
Copy link
Contributor

gptkrsh commented Oct 5, 2021

Not sure why this appears: https://github.com/EddieHubCommunity/LinkFree/pull/452/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519 if you have fixed the package-lock issue

Do you mean I have to change this I have to format it properly and add a new line in it? image

no, I mean why is their a diff between the current package-lock and your package-lock

@Anubhavdevv
Copy link
Member Author

@krishdevdb and @eddiejaoude Now??

@Anubhavdevv
Copy link
Member Author

@eddiejaoude Please review and tell me if any more changes are required?

@Panquesito7
Copy link
Member

Please be patient. @eddiejaoude might be busy with real-life stuff, or they just can't review this PR right now.

@eddiejaoude
Copy link
Member

The package lock file should not be included, but we can accept for this time, next time please only include files you have made changes to yourself and that you want to include

@eddiejaoude eddiejaoude merged commit a7b72f5 into EddieHubCommunity:main Oct 7, 2021
@Anubhavdevv
Copy link
Member Author

Thank you @eddiejaoude For your valuable feedback I will keep these things in mind before contributing

@eddiejaoude
Copy link
Member

You are welcome 👍 , thank you for the contributions 🤓

@shaun-fitzgibbon
Copy link
Member

@Anubhavdevv are you aware that neither of your github or twitter links on LinkFree work ?

Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants