-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
Please remove the package-lock changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review package lock changes
Sure @eddiejaoude Thanks for the review! |
@eddiejaoude Can you please more specific what changes I need to made in package-lock file |
Copy-paste the original file from this repo... |
Now is it good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure doesn't seem done, try again
Simply this json i think: https://raw.githubusercontent.com/anubhav201241/LinkFree/21a5012de9ea8b1eebb07dc978232f0cbf665140/package-lock.json |
Yup I have added this too please review it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this appears: https://github.com/EddieHubCommunity/LinkFree/pull/452/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519 if you have fixed the package-lock issue
Do you mean I have to change this I have to format it properly and add a new line in it? |
no, I mean why is their a diff between the current package-lock and your package-lock |
@krishdevdb and @eddiejaoude Now?? |
@eddiejaoude Please review and tell me if any more changes are required? |
Please be patient. @eddiejaoude might be busy with real-life stuff, or they just can't review this PR right now. |
The package lock file should not be included, but we can accept for this time, next time please only include files you have made changes to yourself and that you want to include |
Thank you @eddiejaoude For your valuable feedback I will keep these things in mind before contributing |
You are welcome 👍 , thank you for the contributions 🤓 |
@Anubhavdevv are you aware that neither of your github or twitter links on LinkFree work ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added anubhav201241.json 🚀