Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add grid layout for user-list ans refactor searchbar component #596

Merged
merged 7 commits into from
Oct 24, 2021
Merged

Add grid layout for user-list ans refactor searchbar component #596

merged 7 commits into from
Oct 24, 2021

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Oct 24, 2021

Closes #583
I have made a couple of changes to this PR

  • Refactor search to its own separate component i.e SearchBar
  • Change inputText type to search

image

  • Fixed typo for users component i.e changed user to users
  • Add grid layout for user list
  1. Large screen

image

  1. Medium screen

image

  1. Small Screen

image

  1. Extra small

image

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@Sachin-chaurasiya
Copy link
Member Author

@eddiejaoude @krishguptadev can you please review this PR?

@Vyvy-vi
Copy link
Member

Vyvy-vi commented Oct 24, 2021

Thank you for contributing to LinkFree.
This PR adds value, however it would be appreciated if unique changes are kept to a specific PR, instead of changing multiple things in one PRs. Moreover, it's best to mention the issue to which this relates in the PR description(with the format closes #pr-number or fixes #pr-number)

Copy link
Member

@Vyvy-vi Vyvy-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...
Though, they don't look centred in
Screenshot 2021-10-24 at 3 33 34 PM

@Sachin-chaurasiya
Copy link
Member Author

Looks good to me... Though, they don't look centred in Screenshot 2021-10-24 at 3 33 34 PM

It basically depends on your screen width size.

@Sachin-chaurasiya
Copy link
Member Author

Thank you for contributing to LinkFree. This PR adds value, however it would be appreciated if unique changes are kept to a specific PR, instead of changing multiple things in one PRs. Moreover, it's best to mention the issue to which this relates in the PR description(with the format closes #pr-number or fixes #pr-number)

Done. I have linked the issue.

@Vyvy-vi
Copy link
Member

Vyvy-vi commented Oct 24, 2021

It basically depends on your screen width size.

Hmm true, this Pr is good to go besides that one thing... That can always be fixed in a later Pr, if needed.

Copy link
Member

@Vyvy-vi Vyvy-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me!

@Vyvy-vi Vyvy-vi merged commit d56d557 into EddieHubCommunity:main Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Proper alignment of user's profile on home page
2 participants