Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Profile added #614

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Profile added #614

merged 4 commits into from
Oct 28, 2021

Conversation

AnanthaRamanathan138
Copy link
Contributor

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes in the package-lock.json and package.json files.

public/data/AnanthaRamanathan138.json Outdated Show resolved Hide resolved
public/data/AnanthaRamanathan138.json Outdated Show resolved Hide resolved
AnanthaRamanathan138 and others added 2 commits October 27, 2021 20:56
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@schmelto schmelto added the ✍ chore: profile This label will be added on PR with request of Data json addition label Oct 27, 2021
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @Panquesito7 instructed you.

Threre are still cahnges in package-lock.json and package.json. Please Revert them.

We can't Approve and Merge with those changes. Your PR should reflect only addition/change in the AnanthaRamanathan138.json file.

Thanks for the contribution :)

Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still see changes in the package-lock.json file. But still, I'm approving this and leaving the decision on the maintainer.

Thanks For the Contribution.

@Vyvy-vi Vyvy-vi merged commit 917a829 into EddieHubCommunity:main Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants