Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

feat(docs): improve navbar navigation to prevent menu collapsing #9827

Merged

Conversation

ArvindParekh
Copy link
Member

@ArvindParekh ArvindParekh commented Nov 24, 2023

Fixes Issue

Closes #9517

Changes proposed

Changed the following lines, to control the collapsing of the main menu (prevent them from collapsing), when sub-menu links are clicked:

--- <Disclosure as="div">
+++ <Disclosure defaultOpen={item.children.some(subItem => subItem.href === pathname)}>

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

After:

2023-11-24.12-16-13.mp4

Before:

2023-11-24.12-34-34.mp4

Note to reviewers

@ArvindParekh ArvindParekh force-pushed the feat/prevent-menu-collapse branch from a947598 to 1c53419 Compare November 26, 2023 01:46
@ArvindParekh ArvindParekh force-pushed the feat/prevent-menu-collapse branch from 1c53419 to e7729b8 Compare November 26, 2023 01:49
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@eddiejaoude eddiejaoude merged commit 5a1e4f2 into EddieHubCommunity:main Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve Docs Page Navigation for Better User Experience
2 participants