Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Remove single use mode #7343 #7350

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Remove single use mode #7343 #7350

merged 1 commit into from
Jun 3, 2023

Conversation

raviraj-github
Copy link
Contributor

@raviraj-github raviraj-github commented Jun 3, 2023

Fixes Issue

Closes #7343

Changes proposed

  • - Removed Single User Layout
  • - Remove Config File(user.json)
  • - Removed Documentation fo Single User
  • - Updated faq.mdx

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

In this fix, we are completely removing the Single User Feature. I don't have information about all the consumers who are currently using this feature. If there are any consumers using this feature, can we deprecate it first? Once all consumers have stopped using it, we can proceed with the removal to ensure we don't break backward compatibility. Although issue #7343 says no one consuming this feature. But I am adding this comment just to double sure.

@github-actions github-actions bot added large Pull request with more than 30 changed lines waiting-for-reviewers labels Jun 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Reviewpad Report

ℹ️ Messages

  • A maintainer will review your pull request soon!

@eddiejaoude
Copy link
Member

That was fast 🚀 ! Look good, I will have a test later on. Thank you 👍

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@eddiejaoude eddiejaoude merged commit 679cca0 into EddieHubCommunity:main Jun 3, 2023
@raviraj-github raviraj-github deleted the LinkFreeI#7343 branch June 3, 2023 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
large Pull request with more than 30 changed lines waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] Remove single use mode
2 participants