-
-
Notifications
You must be signed in to change notification settings - Fork 878
Added Badges And Link to website To README.md #653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to merge this I also would recommend to add links behind the badges
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
@schmelto, I have changed all the badges' names. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! LGTM. 😄👍
@schmelto, this PR can be merged, I think. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side I'm not a big fan of a lot of badges 🙈 so I leave it for @eddiejaoude or someone else to merge :)
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
README.md
Outdated
[![made with markdown](https://forthebadge.com/images/badges/made-with-markdown.svg)](https://forthebadge.com) | ||
[![open source](https://forthebadge.com/images/badges/open-source.svg)](https://forthebadge.com) | ||
[![check it out](https://forthebadge.com/images/badges/check-it-out.svg)](https://forthebadge.com) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also adjust the links here.
- no link at all
- other link than forthebadge
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
Now it has worked :) |
README.md
Outdated
@@ -6,6 +6,11 @@ List of GitHub profiles that have awesome customisation, that you can use for in | |||
|
|||
Feel free to submit a pull request with your suggestions of awesome github profiles. | |||
|
|||
[![made with love](https://forthebadge.com/images/badges/built-with-love.svg)](https://github.com/EddieHubCommunity) | |||
[![made with markdown](https://forthebadge.com/images/badges/made-with-markdown.svg)](https://github.com/EddieHubCommunity) | |||
[![open source](https://forthebadge.com/images/badges/open-source.svg)](https://github.com/EddieHubCommunity) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could link this one to an open source guide or something similar to what the badge is related to (same with the other ones). Just an idea. 🙂
@CodingSpecies i made a pr to your awesome-github-profiles repo by adding a one there badge |
@qwe123coder thank you ! |
@qwe123coder added built by devs
Co-authored-by: David Leal <halfpacho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution! I love the badges! They look so cool. 😄👍🎉
I added an area showing the link to the website, I don't know how to make a new pull request, while I have another pr open as well, so it is here too. thanks |
To make another pull request while you have another one open, you must create another branch, implement your changes, and make a pull request. I hope that helps. 😄 |
@Panquesito7 thank you I will do that next time! |
Co-authored-by: David Leal <halfpacho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contributions, @CodingSpecies! It is greatly appreciated. 😄👍🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I wasn't meant to add this commit here! I will try to fix it. |
Going to open new pr |
Great to see lots of collaboration going on here 🎉 |
I added these badges to the README.md, thank you.