Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

Added Badges And Link to website To README.md #653

Closed
wants to merge 16 commits into from
Closed

Added Badges And Link to website To README.md #653

wants to merge 16 commits into from

Conversation

NS007-dev
Copy link
Member

I added these badges to the README.md, thank you.

forthebadge forthebadge forthebadge forthebadge

Copy link
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to merge this I also would recommend to add links behind the badges

README.md Outdated Show resolved Hide resolved
NS007-dev and others added 2 commits August 18, 2021 10:39
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
@NS007-dev
Copy link
Member Author

@schmelto, I have changed all the badges' names. thanks

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! LGTM. 😄👍

@Panquesito7
Copy link
Member

@schmelto, this PR can be merged, I think. 🙂

Copy link
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side I'm not a big fan of a lot of badges 🙈 so I leave it for @eddiejaoude or someone else to merge :)

README.md Outdated Show resolved Hide resolved
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 10 to 13
[![made with markdown](https://forthebadge.com/images/badges/made-with-markdown.svg)](https://forthebadge.com)
[![open source](https://forthebadge.com/images/badges/open-source.svg)](https://forthebadge.com)
[![check it out](https://forthebadge.com/images/badges/check-it-out.svg)](https://forthebadge.com)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also adjust the links here.

  1. no link at all
  2. other link than forthebadge

@NS007-dev
Copy link
Member Author

it doesn't seem to work now:
image

NS007-dev and others added 2 commits August 19, 2021 08:35
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
@NS007-dev
Copy link
Member Author

Now it has worked :)

README.md Outdated
@@ -6,6 +6,11 @@ List of GitHub profiles that have awesome customisation, that you can use for in

Feel free to submit a pull request with your suggestions of awesome github profiles.

[![made with love](https://forthebadge.com/images/badges/built-with-love.svg)](https://github.com/EddieHubCommunity)
[![made with markdown](https://forthebadge.com/images/badges/made-with-markdown.svg)](https://github.com/EddieHubCommunity)
[![open source](https://forthebadge.com/images/badges/open-source.svg)](https://github.com/EddieHubCommunity)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could link this one to an open source guide or something similar to what the badge is related to (same with the other ones). Just an idea. 🙂

@qwel-exe
Copy link
Member

@CodingSpecies i made a pr to your awesome-github-profiles repo by adding a one there badge
merge that pr so it also gets committed hear :)

@NS007-dev
Copy link
Member Author

@qwe123coder thank you !

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! I love the badges! They look so cool. 😄👍🎉

@NS007-dev
Copy link
Member Author

I added an area showing the link to the website, I don't know how to make a new pull request, while I have another pr open as well, so it is here too. thanks

@Panquesito7
Copy link
Member

I don't know how to make a new pull request, while I have another PR open

To make another pull request while you have another one open, you must create another branch, implement your changes, and make a pull request. I hope that helps. 😄

@NS007-dev
Copy link
Member Author

NS007-dev commented Aug 22, 2021

@Panquesito7 thank you I will do that next time!

README.md Outdated Show resolved Hide resolved
Co-authored-by: David Leal <halfpacho@gmail.com>
@NS007-dev NS007-dev changed the title Added Badges To README.md Added Badges And Link to website To README.md Aug 22, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contributions, @CodingSpecies! It is greatly appreciated. 😄👍🎉

Copy link
Member

@Vyvy-vi Vyvy-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NS007-dev
Copy link
Member Author

I wasn't meant to add this commit here! I will try to fix it.

@NS007-dev
Copy link
Member Author

Going to open new pr

@eddiejaoude
Copy link
Member

Great to see lots of collaboration going on here 🎉

@NS007-dev NS007-dev mentioned this pull request Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants