Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

Omkar0114 #714

Merged
merged 10 commits into from
Oct 16, 2021
Merged

Omkar0114 #714

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
afa78b0
username added
Omkar0114 Sep 9, 2021
0e50aa1
Merge pull request #1 from Omkar0114/Omkar0114-patch-1
Omkar0114 Sep 9, 2021
0bd33aa
update link
Omkar0114 Sep 9, 2021
0f458ca
update image URL
Omkar0114 Sep 14, 2021
ee1a042
username added
Omkar0114 Sep 14, 2021
0dd3c0c
update link and extra spaces
Omkar0114 Sep 15, 2021
e8094be
Update data.json
Omkar0114 Oct 15, 2021
917f43b
Merge branch 'main' into main
Omkar0114 Oct 15, 2021
f03d589
Update data.json
Omkar0114 Oct 15, 2021
38389b8
Added comma on line 1333
Omkar0114 Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,5 +1324,11 @@
"githubUsername": "Krishnapro",
"imageUrl": "https://user-images.githubusercontent.com/59277887/132136661-d62a6664-0fa3-437d-b97d-ea41ca21c61f.png",
"issueNumber": 702
}
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
{

"name": "Omkar Kulkarni",
"githubUsername": "Omkar0114",
"imageUrl": "https://user-images.githubusercontent.com/88308267/133253323-504843cd-f744-4962-8c8a-3b44c76d7b87.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend more of an image like this.

image

Suggested change
"imageUrl": "https://user-images.githubusercontent.com/88308267/133253323-504843cd-f744-4962-8c8a-3b44c76d7b87.png",
"imageUrl": "https://user-images.githubusercontent.com/51391473/133314407-008ec664-bdbd-4428-a9c4-8c306f74a91c.png",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated link

"issueNumber": 713
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed extra spaces

]