Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

add Nandani-Paliwal profile #761

Closed
wants to merge 5 commits into from
Closed

add Nandani-Paliwal profile #761

wants to merge 5 commits into from

Conversation

Nandani-Paliwal
Copy link
Member

resolve #760

data.json Outdated
@@ -1421,4 +1421,9 @@
"imageUrl": "https://user-images.githubusercontent.com/41515472/135764171-9fbac687-0017-449f-815d-527dc6b5f44f.jpg",
"issueNumber": 754
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
},

data.json Outdated
@@ -1421,4 +1421,9 @@
"imageUrl": "https://user-images.githubusercontent.com/41515472/135764171-9fbac687-0017-449f-815d-527dc6b5f44f.jpg",
"issueNumber": 754
}
]
] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
] {
{

data.json Outdated
"githubUsername": "Nandani-Paliwal",
"imageUrl":"https://user-images.githubusercontent.com/83964826/136408997-e2fcefa5-2c78-4484-9ac3-574bd72da253.PNG",
"issueNumber": 760
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}
]

Copy link
Member

@rakesh0x7 rakesh0x7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Can you please make required changes

@Nandani-Paliwal
Copy link
Member Author

Hey! Can you please make required changes

@deephunt3r Is it fine now?

data.json Outdated
@@ -1420,5 +1420,11 @@
"githubUsername": "cankush625",
"imageUrl": "https://user-images.githubusercontent.com/41515472/135764171-9fbac687-0017-449f-815d-527dc6b5f44f.jpg",
"issueNumber": 754
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
{

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change!

thanks for the mention ,sorry too😅

Copy link
Member

@rakesh0x7 rakesh0x7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution 🚀

@rakesh0x7
Copy link
Member

Hey @Nandani-Paliwal ,I just approved the changes! The maintainers will review and they will merge it soon! 😄

@Nandani-Paliwal
Copy link
Member Author

Hey @Nandani-Paliwal ,I just approved the changes! The maintainers will review and they will merge it soon! 😄 thanks for reviewing it,that ping was done by mistake....sorry for that !!😅

data.json Outdated
{
"name": "Nandani Paliwal",
"githubUsername": "Nandani-Paliwal",
"imageUrl":"https://user-images.githubusercontent.com/83964826/136408997-e2fcefa5-2c78-4484-9ac3-574bd72da253.PNG",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"imageUrl":"https://user-images.githubusercontent.com/83964826/136408997-e2fcefa5-2c78-4484-9ac3-574bd72da253.PNG",
"imageUrl": "https://user-images.githubusercontent.com/83964826/136408997-e2fcefa5-2c78-4484-9ac3-574bd72da253.PNG",

"githubUsername": "Nandani-Paliwal",
"imageUrl": "https://user-images.githubusercontent.com/83964826/136408997-e2fcefa5-2c78-4484-9ac3-574bd72da253.PNG",
"issueNumber": 760
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
}

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments by @schmelto.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nandani
4 participants