-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duration does not seem to accept values on "show" and "showWithOptions"methods (Android 8.0) #117
Comments
Any chances to receive some feedback on the above issue? |
Same issue. Only on android. |
@EddyVerbruggen - any chances to see this issue updated soon? |
Not by me, perhaps someone else. |
Any idea how to move it forward? It was reported two months ago and basically, nobody gives an attention... |
any chances to see this issue updated soon? |
guys - anyone able to at least elaborate on the issue? It's been almost three months since I reported it and so far nobody gives any valuable feedback... |
it work for me: |
2.7.1 is now compatible with any Android version, but it may have implications for how long the Toast is shown. It is what it is. |
@EddyVerbruggen - actually it does not fix the issue described above - at least not on the OS and the device reported by me. Hence I think the issue shouldn't been closed. |
I’d be happy to merge a PR to fix your issue, but I want to be transparent that there’s no fix to be expected by me. |
I must say I am a bit confused here - I have reported a bug for Android 8.0, confirmed by others as well. It has not been fixed, yet, the issue has been closed. I stand by my words - the issue should not been closed, since it has not been actually fixed. |
Happy to reopen, I’m just giving you a heads up I will not be fixing this any time soon, so you don’t have false expectations. IMO it’s better to have a working Toast on all Android versions (fix in 2.7.1) than supporting a duration on all versions (it does work on some, but I don’t know which exactly). |
Thanks, mate. |
Thank you. Btw, I noticed 2.7.1 ignores even the 'short' and 'long' duration settings (always 'long'). 2.7.2 fixes that. |
Thanks, Eddy. Just to get this one straight - the user can set ether |
I've tested these 3 (from the readme): <button onclick="window.plugins.toast.showShortTop('Hello there!', function(a){console.log('toast success: ' + a)}, function(b){alert('toast error: ' + b)})">Toast showShortTop</button>
<button onclick="window.plugins.toast.showLongBottom('Hello there!', function(a){console.log('toast success: ' + a)}, function(b){alert('toast error: ' + b)})">Toast showLongBottom</button>
<button onclick="window.plugins.toast.show('Hello there!', 'long', 'center', function(a){console.log('toast success: ' + a)}, function(b){alert('toast error: ' + b)})">Toast show long center</button> And all of those respect the short/long setting. |
Expected behaviour
duration
param should be adjustable and should allow to set different times e.g. 10000.Actual behaviour
Neither of methods -
show
norshowWithOptions
seems to keep toast alive for more than 3000 (3 secs).I'm seeing this behaviour on
Hardware models
Samsung Galaxy S8
OS versions
Android 8.0
I'm not a dummy, so I've checked these
deviceready
to fire.window.onerror
catches nothing).So how can we reproduce this?
The below code snippet should suffice in reproduction steps:
Note: I had a chance to test the very same code snippet above on Xiaomi Redmi Note 4 / Android 7.0 and everything works just fine (the
duration
has been properly respected by the plugin). It seems the issue is due to OS version, since it is present on the emulator, which runs on Android 8.0 as well.The text was updated successfully, but these errors were encountered: