cordova/android 7.1 and gradle compatibility #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 9, 2018 07:35
smxdevst
approved these changes
Jan 17, 2019
|
@EddyVerbruggen please merge this pull request. Plugin not being installed on Android together with cordova-plugin-ionic-keyboard |
|
@EddyVerbruggen A reminder to please merge this pull request. Also experiencing this issue on cordova android 7.1.4 |
|
The reason I didn't yet is that I'm afraid it breaks backward compatibility. But I'll bump the major version and no longer worry about it. Thanks all! |
|
Closes #100. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current plugin.xml doesn't work on latest cordova due error on FontAwesome copy and license is not filled our correctly. After experimenting I found that this works without problems. No issues on adding plugin, building project and using it.