Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

NS7+Ng10 Admob Smartbanner error: Invalid ad width or height: (0, 0) on v11.0.0 (iOS 14 only) #1683

Open
ngocnt1 opened this issue Sep 29, 2020 · 3 comments

Comments

@ngocnt1
Copy link

ngocnt1 commented Sep 29, 2020

√ Getting NativeScript components versions information...
√ Component nativescript has 7.0.8 version and is up to date.
√ Component @nativescript/core has 7.0.7 version and is up to date.
√ Component @nativescript/ios has 7.0.0 version and is up to date.
√ Component @nativescript/android has 7.0.0 version and is up to date.

iOS 14.0+, @nativescript/firebase@^11.0.0

i got "Invalid ad width or height: (0, 0)" all the times with smart banner request.
it works well with normal banner.

@ngocnt1
Copy link
Author

ngocnt1 commented Oct 2, 2020

Hi @EddyVerbruggen ,
i investigated this issue on my app, i found initWithAdSizeOrigin is no longer return Bannerview with correct AdSize, that why it's throwing "Invalid ad width or height: (0, 0)" when my app try to get a smart banner ad.

i want to create an PR but i don't now where is the v11.0.0 branch for NS7.

@EddyVerbruggen
Copy link
Owner

Hi! Feel free to send it to master instead.

ngocnt1 added a commit to ngocnt1/nativescript-plugin-firebase that referenced this issue Oct 2, 2020
@ngocnt1
Copy link
Author

ngocnt1 commented Nov 9, 2020

Hi @EddyVerbruggen , do you have a second to have a look on this? i still got stuck with the smartbanner ads on 11.1.3 if without this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants