(ZcashPiratechain) Add error listeners #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Sep 2, 2024
src/piratechain/piratechainTypes.ts
Outdated
Comment on lines
92
to
94
| export const asPiratechainBlockRange = asObject({ | ||
| first: asNumber, | ||
| last: asNumber | ||
| }) |
There was a problem hiding this comment.
You can keep this and pass the generic type argument to asObject<BlockRange> to ensure the cleaner matches the type.
samholmes
approved these changes
Sep 3, 2024
The UnifiedViewingKey type is unrelated to error handling but no longer exists
peachbits
force-pushed
the
matthew/privacy-coin-error-listeners
branch
from
88db856
to
7ef3d1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/react-native-piratechain#14
EdgeApp/react-native-zcash#56
Description
none