Add redundancy to Cardano queries #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By far, the slowest query is `address_txs` and we don't know how many times we have to query it but it does return 1000 txs at a time. We can't provide any progress updates until we get the list of txids and break them up. The first query takes so long that the end result isn't remarkably better than the original. Breaking up the second info query into chunks technically makes syncing take longer with the "benefit" that maybe we'll see actual progress in the sync ratio. This commit is optional and I can be convinced it isn't necessary.
peachbits
force-pushed
the
matthew/koios
branch
from
4a47ee2
to
5b6bec9
Compare
swansontec
approved these changes
Oct 1, 2024
swansontec
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
I don't know about the second commit either, but psychologically people are OK with things being slow as long as they get progress. It's easier to wait a week with tracking info that wait 4-5 days without tracking information, so I'm generally in favor of this sort of thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none