Fix AVAX missing transaction confirmations #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
requested changes
Oct 3, 2024
src/ethereum/ethereumTypes.ts
Outdated
| @@ -73,6 +73,7 @@ export interface ChainParams { | |||
| } | |||
|
|
|||
| export interface EthereumNetworkInfo { | |||
| addressQueryLookbackBlocks?: number | |||
There was a problem hiding this comment.
Every info file features it so let's make it mandatory
peachbits
requested changes
Oct 3, 2024
src/ethereum/EthereumNetwork.ts
Outdated
| @@ -361,10 +360,12 @@ export class EthereumNetwork { | |||
| this.ethEngine.walletLocalData.lastTransactionDate[ | |||
| currencyCode | |||
| ] ?? 0 | |||
| const addressQueryLookbackBlocks = | |||
| this.ethEngine.networkInfo.addressQueryLookbackBlocks ?? 0 | |||
There was a problem hiding this comment.
The nullish coalescing operator isn't useful
peachbits
approved these changes
Oct 3, 2024
samholmes
force-pushed
the
sam/pending-tx-bug
branch
from
7240d62
to
04d4414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none