-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TON #847
Add TON #847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small changes. Overall this is pretty good.
src/ton/TonEngine.ts
Outdated
await promiseAny(broadcastFuncs) | ||
|
||
if (this.otherData.contractState === 'uninitialized') { | ||
// It's not possible to calculate the txid for a wallet's first send so We need to look for it once it's confirmed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo in comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did the rest of the comments go? Ugh, GitHub lost most of my review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had about 6 comments on this PR, but GitHub lost them, and now I don't remember what they were. These are the important ones.
src/ton/TonEngine.ts
Outdated
edgeSpendInfoIn.skipChecks !== true && | ||
gt(add(total, this.networkInfo.minimumAddressBalance), balance) | ||
) { | ||
throw new Error('InsufficientFundsError') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. Please do new InsufficientFundsError({ tokenId })
src/ton/TonTools.ts
Outdated
} | ||
|
||
async updateClients(): Promise<void> { | ||
const res = await this.io.fetchCors(this.networkInfo.orbsNetworkUrl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a job for the info server. The info server payload for TON should include an orbsUrls
field, and then we should have a background process on the info server that fetches this information and shoves it in CouchDB. Then, the core info endpoint would merge the orbsUrls
field into the payload on it way out the door.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
9dc3e4a
to
591f551
Compare
Necessary for moving seeds between wallets
591f551
to
a0dc1ce
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none