Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TON #847

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Add TON #847

merged 7 commits into from
Oct 31, 2024

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Oct 24, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

@peachbits peachbits mentioned this pull request Oct 24, 2024
6 tasks
Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes. Overall this is pretty good.

await promiseAny(broadcastFuncs)

if (this.otherData.contractState === 'uninitialized') {
// It's not possible to calculate the txid for a wallet's first send so We need to look for it once it's confirmed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in comment.

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did the rest of the comments go? Ugh, GitHub lost most of my review.

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had about 6 comments on this PR, but GitHub lost them, and now I don't remember what they were. These are the important ones.

edgeSpendInfoIn.skipChecks !== true &&
gt(add(total, this.networkInfo.minimumAddressBalance), balance)
) {
throw new Error('InsufficientFundsError')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. Please do new InsufficientFundsError({ tokenId })

}

async updateClients(): Promise<void> {
const res = await this.io.fetchCors(this.networkInfo.orbsNetworkUrl)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a job for the info server. The info server payload for TON should include an orbsUrls field, and then we should have a background process on the info server that fetches this information and shoves it in CouchDB. Then, the core info endpoint would merge the orbsUrls field into the payload on it way out the door.

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@peachbits peachbits merged commit 4bb0a3f into master Oct 31, 2024
2 checks passed
@peachbits peachbits deleted the matthew/ton branch October 31, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants