Fix Cardano UTXO and balance bugs #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network queries would result in overwriting local UTXO state without considering that the UTXOs may have already been spent and the network is out of date. The solution is to always merge unseen UTXOs from the network into the the wallet state, and ignore UTXOs that have already been seen by the wallet. This algorithm assumes that the network will catch-up with the wallet well before the wallet is restarted/resync'd because the `seenVouts` state is ephemeral. If it were to persist engine restarts, then the only bug surface area is if the user resyncs (destroying any persisted state for the wallet). This is generally how UTXO plugins work, but doesn't appear to be necessary for Cardano due to it's fast block times.
samholmes
force-pushed
the
sam/ada-utxo-stomping
branch
from
f7348f4
to
aee4bb4
Compare
swansontec
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none