Format Cleanup #280
Draft
Format Cleanup #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a single algorithm responsible for getting a wallet's primaryFormat. This function uses the existing algorithm for publicKeys and is now also used in `createPrivateKey`. This change should be an idempotent, but guarantees our future changes (about how we select the primary key) is couple to the appropriate routines. The goal is to future-proof our existing implementation for when we enable new wallet formats. We do not introduce any side-effects to existing wallets (wallets already persisted prior to any change).
samholmes
force-pushed
the
sam/format-cleanup
branch
from
45f9717 to
a2e5f2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.