Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist plugins for ChangeHero plugin #294

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Whitelist plugins for ChangeHero plugin #294

merged 2 commits into from
Oct 9, 2023

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Oct 6, 2023 •
edited
Loading

We can't rely on their blockchain names to match ours so we need to whitelist them manually

swansontec
swansontec requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change needed.

src/swap/changehero.ts Outdated Show resolved Hide resolved
@peachbits
Replace deprecated currency codes in SwapCurrencyError with request
927b366
@peachbits
Whitelist plugins for ChangeHero plugin
2ebd1bf 
We can't rely on their blockchain names to match ours so we need to whitelist them manually
@peachbits peachbits force-pushed the matthew/ftmChangehero branch from fb9e3fd to 2ebd1bf Compare October 6, 2023 23:34
@peachbits peachbits merged commit ba0c480 into master Oct 9, 2023
1 check passed
@peachbits peachbits deleted the matthew/ftmChangehero branch October 9, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swansontec swansontec swansontec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peachbits @swansontec