Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native build #297

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Add native build #297

merged 4 commits into from
Oct 24, 2023

Conversation

swansontec
Copy link
Contributor

@swansontec swansontec commented Oct 19, 2023

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

@swansontec swansontec changed the title William/native build Add native build Oct 19, 2023
Copy link
Contributor

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions

src/index.ts Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -3,6 +3,7 @@
## Unreleased

- changed: Simplify our React Native integration.
- removed: Delete all rate plugins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the rates plugins removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a breaking change, we agreed to finally remove these plugins, which are no longer used or maintained.

@swansontec swansontec force-pushed the william/native-build branch from b8fb41d to b4c54a4 Compare October 23, 2023 21:44
@swansontec
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the william/native-build branch from b4c54a4 to e5b37f6 Compare October 23, 2023 23:22
@swansontec swansontec enabled auto-merge October 23, 2023 23:29
@swansontec swansontec force-pushed the william/native-build branch from e5b37f6 to e27e10f Compare October 24, 2023 17:26
@swansontec swansontec merged commit 827004c into master Oct 24, 2023
1 check passed
@swansontec swansontec deleted the william/native-build branch October 24, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants