Return txid as orderId for DEX swaps when calling approve() #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Jun 24, 2024
src/util/swapHelpers.ts
Outdated
| @@ -160,6 +160,10 @@ export async function makeSwapPluginQuote( | |||
| savedAction.orderUri = `${savedAction.orderUri}${tx.txid}` | |||
| } | |||
|
|
|||
| if (quoteId == null && (swapInfo.isDex ?? false)) { | |||
There was a problem hiding this comment.
Doing (swapInfo.isDex === true) also avoids the lint error, but makes more sense when you read it.
peachbits
force-pushed
the
matthew/txidAsOrderId
branch
from
37cdf77 to
7e587c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none