Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove partial flag from thorchain and maya protocol #350

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Nov 8, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify with Paul?

Maybe also just delete the isEstimate flag altogether, since we don't support / don't want streaming swaps.

The swaps won't be partial with isEstimate set to true. We'll keep the code in place in case we turn that functionality back on.
@peachbits peachbits force-pushed the matthew/remove-partial branch from 22112f4 to 8b26753 Compare November 11, 2024 20:14
@peachbits peachbits merged commit 71a3ccd into master Nov 11, 2024
1 check passed
@swansontec swansontec deleted the matthew/remove-partial branch November 13, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants